]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
overview: Always return a value in _onDragMotion()
authorFlorian Müllner <fmuellner@gnome.org>
Thu, 20 Jan 2011 15:46:55 +0000 (16:46 +0100)
committerFlorian Müllner <fmuellner@gnome.org>
Thu, 20 Jan 2011 16:04:38 +0000 (17:04 +0100)
Drag monitor functions are supposed to return a value, but
_onDragMotion() does not always do so. Add the missing return
value and remove unnecessary else.

js/ui/overview.js

index 7aa24237ea179b42f415ebb95dbd5ec3d6196f7f..35c1b05c415b344cfd49e7a6426041c08ec44085 100644 (file)
@@ -207,9 +207,9 @@ Overview.prototype = {
 
         if (targetIsWindow &&
             dragEvent.targetActor._delegate.metaWindow == this._lastHoveredWindow)
-            return;
-        else
-            this._lastHoveredWindow = null;
+            return DND.DragMotionResult.CONTINUE;
+
+        this._lastHoveredWindow = null;
 
         if (this._windowSwitchTimeoutId != 0) {
             Mainloop.source_remove(this._windowSwitchTimeoutId);